Skip to content

Conversation

@github-actions
Copy link
Contributor

It requires the version to be bumped first in golang-crossbuild project, then a new release will be added to:
https://github.com/elastic/golang-crossbuild/releases/tag/v1.24.1.
Otherwise it will fail until the docker images are available.


Bump golang-version to latest version

Update .go-version

1 file(s) updated with "1.24.1": * .go-version

1.24.1
no GitHub Release found for go1.24.1 on "https://github.com/golang/go"
Update version.asciidoc

1 file(s) updated with ":go-version: 1.24.1": * version/docs/version.asciidoc

1.24.1
no GitHub Release found for go1.24.1 on "https://github.com/golang/go"
Update from dockerfiles

2 file(s) updated with "ARG GO_VERSION=1.24.1": * Dockerfile * Dockerfile.skaffold

1.24.1
no GitHub Release found for go1.24.1 on "https://github.com/golang/go"
Update go.mod version

1 file(s) updated with "go 1.24.1": * go.mod

1.24.1
no GitHub Release found for go1.24.1 on "https://github.com/golang/go"
GitHub Action workflow link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
@github-actions github-actions bot requested a review from a team as a code owner March 18, 2025 18:14
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 19, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pkoutsovasilis
Copy link
Contributor

I see what's the problem here, and I am gonna commit a fix soon 🙂

@elastic-sonarqube
Copy link

@jlind23 jlind23 enabled auto-merge (squash) March 24, 2025 19:14
@jlind23 jlind23 disabled auto-merge March 24, 2025 19:14
Copy link
Contributor

@pazone pazone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll create a follow-up PR that deletes golang from .tools-versions. It's being overwritten by .go-version

@v1v
Copy link
Member

v1v commented Mar 24, 2025

However, I see there are some missing changes compared to #6932:

  • .buildkite/pipeline.yml
  • changelog
  • pkg/testing/runner/runner_test.go

Is that expected?


Just in case, I raised #7540 to actually update the two files.

My question about the changelog needs some clarity too, is that expected to be in there?

@jlind23
Copy link
Contributor

jlind23 commented Mar 24, 2025

@v1v i believe that @pazone might be best to answer your question here.

@v1v v1v mentioned this pull request Mar 24, 2025
8 tasks
@pazone
Copy link
Contributor

pazone commented Mar 24, 2025

  • .buildkite/pipeline.yml - the merge coverage is a utility step, not related to agent functionality
  • pkg/testing/runner/runner_test.go - a unit test for integration tests runner. The go version is specified to create the config and is not used in the test. I don't think it's necessary to update them. A follow-up would be fine
  • It looks like the fragment changelog/fragments/1723829102-Upgrade-to-Go-1.23.0.yaml was mistakenly updated last time.
    One unit test failed due to a known issue that is not related to this repository. Retried them

@pchila pchila merged commit 0dc58a0 into main Mar 25, 2025
12 checks passed
@pchila pchila deleted the updatecli_main_901223529a6beca5c9cb3180f1dae9731c8da4e9c40169d7042cc0163a6d7e24 branch March 25, 2025 06:25
@jlind23 jlind23 added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Mar 25, 2025
mergify bot pushed a commit that referenced this pull request Mar 25, 2025
* chore: Update from dockerfiles

Made with ❤️️ by updatecli

* chore: Update version.asciidoc

Made with ❤️️ by updatecli

* chore: Update go.mod version

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* fix: install gotestsum inside buildkite-k8s-integration-tests.sh

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michel Laterman <[email protected]>
Co-authored-by: simitt <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Panos Koutsovasilis <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0dc58a0)
mergify bot pushed a commit that referenced this pull request Mar 25, 2025
* chore: Update from dockerfiles

Made with ❤️️ by updatecli

* chore: Update version.asciidoc

Made with ❤️️ by updatecli

* chore: Update go.mod version

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* fix: install gotestsum inside buildkite-k8s-integration-tests.sh

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michel Laterman <[email protected]>
Co-authored-by: simitt <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Panos Koutsovasilis <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0dc58a0)
jlind23 pushed a commit that referenced this pull request Mar 25, 2025
* chore: Update from dockerfiles

Made with ❤️️ by updatecli

* chore: Update version.asciidoc

Made with ❤️️ by updatecli

* chore: Update go.mod version

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* fix: install gotestsum inside buildkite-k8s-integration-tests.sh

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michel Laterman <[email protected]>
Co-authored-by: simitt <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Panos Koutsovasilis <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0dc58a0)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ebeahan ebeahan added the backport-8.18 Automated backport to the 8.18 branch label Apr 2, 2025
mergify bot pushed a commit that referenced this pull request Apr 2, 2025
* chore: Update from dockerfiles

Made with ❤️️ by updatecli

* chore: Update version.asciidoc

Made with ❤️️ by updatecli

* chore: Update go.mod version

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* fix: install gotestsum inside buildkite-k8s-integration-tests.sh

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michel Laterman <[email protected]>
Co-authored-by: simitt <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Panos Koutsovasilis <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0dc58a0)
pkoutsovasilis pushed a commit that referenced this pull request Apr 2, 2025
* chore: Update from dockerfiles

Made with ❤️️ by updatecli

* chore: Update version.asciidoc

Made with ❤️️ by updatecli

* chore: Update go.mod version

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* fix: install gotestsum inside buildkite-k8s-integration-tests.sh

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michel Laterman <[email protected]>
Co-authored-by: simitt <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Panos Koutsovasilis <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0dc58a0)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ebeahan pushed a commit that referenced this pull request Apr 2, 2025
* chore: Update from dockerfiles

Made with ❤️️ by updatecli

* chore: Update version.asciidoc

Made with ❤️️ by updatecli

* chore: Update go.mod version

Made with ❤️️ by updatecli

* chore: Update .go-version

Made with ❤️️ by updatecli

* fix: install gotestsum inside buildkite-k8s-integration-tests.sh

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michel Laterman <[email protected]>
Co-authored-by: simitt <[email protected]>
Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Panos Koutsovasilis <[email protected]>
Co-authored-by: Julien Lind <[email protected]>
(cherry picked from commit 0dc58a0)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch backport-skip skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.